-
Notifications
You must be signed in to change notification settings - Fork 2
Rewrite resource storage and add mimic test #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
===========================================
+ Coverage 61.44% 75.61% +14.17%
===========================================
Files 3 4 +1
Lines 249 324 +75
Branches 42 35 -7
===========================================
+ Hits 153 245 +92
+ Misses 75 55 -20
- Partials 21 24 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
0e1e869 to
b3bb2b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think these changes work great and I was able to test it on my robots Isaac config and everything still works as expected.
How do we want to handle all of the CI failures till the upstream changes get synced?
...erface/include/joint_state_topic_hardware_interface/joint_state_topic_hardware_interface.hpp
Show resolved
Hide resolved
As semi-binary CI is green, it should be fine |
I changed the storage of the component to be handled by the resource manager instead of inside of the component (deprecated).
The initial values of the handles are set by the RM -> removes some code here.
Mimic handling is similar to ros-controls/ros2_control#2571
I added a mimicked gripper integration test (similar to gz_ros2_control_demos) and also extended the gmock test to actually test some stuff (adapted from GenericSystem).
I fixed the behavior to accept joint_states from the robot with missing position interfaces, see
topic_based_system_2dof_velocity_only. But it throws and deactivates if a topic with position fields is received but no state interfaces are configured, seetopic_based_system_2dof_velocity_only_inconsistent_topic. Is this the intended behavior?