Skip to content

Conversation

kylerlaird
Copy link

No description provided.

The driver is now configured using standard ROS parameters.
If a ROS topic is provided via the "rtcm" parameter, Strings on this topic will be passed to the device as RTCM corrections (packet ID 55).
Yaw has been corrected to conform with REP 103.
ros-drivers#3

RTCM corrections can be passed from a topic (as Strings).

A UTM-based transform can be generated.
I uploaded the wrong file last time.  See previous commit.
added instructions for RTCM and TF usage, notification of REP 103 compliance
I changed the parameter names again.

I added a note about the new Odometry feature.
I'm trying to standardize the parameter names (to be more like Robotnik's).

I added Odometry message output if utm_zone is provided.
Even at only 20 Hz, the driver always consumed 100% CPU time.  I found that it was polling without any delay/throttling.

I configured the Linux version of OpenComport() for blocking reads.  CPU time dropped to 5%.
I added a note about blocking serial port reads for Linux.
Rather than specify topic and frame names using parameters, I named them relative to the current namespace.
@RonaldEnsing
Copy link

RonaldEnsing commented Jun 26, 2018

The nav_msgs::Odometry message, as published by the advanced_navigation_driver node in this PR, seems to be incompatible with the odometry message conventions, making it impossible to use the odometry message with other packages such as robot localization[1].

The ROS documentation for odometry messages [2] states: "The twist in this message should be specified in the coordinate frame given by the child_frame_id."

The child_frame_id of the odometry message is set to ins. However, the values are assigned from system state packet with id 20, field 8, 9 and 10, which reports the velocities in the global frame: North, East, Down coordinates, as can be seen in the Spatial Dual Reference Manual.

[1] http://wiki.ros.org/robot_localization
[2] http://docs.ros.org/kinetic/api/nav_msgs/html/msg/Odometry.html

P.S. I wanted to create an issue on this on the fork of @kylerlaird , but issues are disabled on that forked repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants