Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr update versions #418

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

rkent
Copy link

@rkent rkent commented Sep 10, 2024

This patch started with deleting Gemfile.lock, recreating, then fixing regressions. The Gemfile.lock update was done 2024-07-17 (or earlier, not sure). The additional commits are for regressions.

Biggest change is probably switching from redcarpet to kramdown for markdown. I did not try to understand the redcarpet options, and try to map them to kramdown, I just kept the existing kramdown configurations.

I've been running this for awhile at index.rosdabbler.com, and am not aware of any issues. But I really know very little about the ruby universe.

_plugins/redcarpet_toc.rb is misnamed, it does not require redcarpet, but I did not rename.

@tfoote
Copy link
Member

tfoote commented Sep 15, 2024

This needs a rebase as it has a conflict in _config.yml

Fixes #307

@rkent
Copy link
Author

rkent commented Sep 16, 2024

Rebase completed.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup. Ruby's always a pain to update.

I tested this out on my machine as well and it seemed to work. So we'll give it a try.

@tfoote tfoote merged commit c3694da into ros-infrastructure:ros2 Sep 24, 2024
1 check passed
@rkent rkent deleted the pr-update-versions branch September 25, 2024 04:09
@tfoote
Copy link
Member

tfoote commented Sep 25, 2024

Also as a side note I ran a build after this and the build time changed from 327 minutes elapsed to 247 minutes elapsed to build/ That's a 25% speedup!

image

The console log verbosity is way down 604122 vs 447902 lines of output. Most of those are likely are related to fixing #307

@rkent
Copy link
Author

rkent commented Sep 26, 2024

And all this time I though you liked verbosity!

A lot of the rosindex verbosity comes from the --verbose option in the Makefile. I've removed that in my dev versions.

@tfoote
Copy link
Member

tfoote commented Sep 26, 2024

I do like verbosity that communicates information ;) Repeated and redundant information is not helpful. I've trolled through a lot of logs and being able to find the information there is what's important especially for things like this that are very hard to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants