Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CXX standards for log4cxx #190

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from
Open

Drop CXX standards for log4cxx #190

wants to merge 1 commit into from

Conversation

jspricke
Copy link
Member

No description provided.

@clalancette
Copy link
Contributor

This seems generally fine to me, though I will note that it will "upgrade" robot_state_publisher from C++11 to C++14 in Noetic. That's allowed by REP-3, but it is a change.

@sloretz Thoughts about this?

@sloretz
Copy link
Contributor

sloretz commented Feb 18, 2022

though I will note that it will "upgrade" robot_state_publisher from C++11 to C++14 in Noetic. That's allowed by REP-3, but it is a change.

Does changing the CXX standard from 11 to 14 have any affects on ABI when using gcc? If not, this seems fine to me.

@jspricke
Copy link
Member Author

jspricke commented Feb 18, 2022 via email

@ahcorde ahcorde added the ros1 label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ros1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jspricke @clalancette @sloretz @ahcorde @lepalom