Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log errors in XmlRpcpp #2277

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from
Open

Log errors in XmlRpcpp #2277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion utilities/xmlrpcpp/src/XmlRpcUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ static class DefaultErrorHandler : public XmlRpcErrorHandler {
void error(const char* msg) {
OutputDebugString(msg); OutputDebugString("\n");
#else
void error(const char*) {
void error(const char* msg) {
#endif
// As far as I can tell, throwing an exception here is a bug, unless
// the intention is that the program should exit. Throughout the code,
Expand All @@ -64,6 +64,7 @@ static class DefaultErrorHandler : public XmlRpcErrorHandler {
// So I'm commenting out the throw. - BPG
//
//throw std::runtime_error(msg);
defaultLogHandler.log(0, msg);
}
} defaultErrorHandler;

Expand Down