-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PySide6 to rosdep keys #42353
base: master
Are you sure you want to change the base?
Add PySide6 to rosdep keys #42353
Conversation
Standard pip disclaimer: ROS packages that depend on pip keys cannot be released into a ROS distribution. They can only be depended on by from-source builds. Because of this, system packages are highly preferred to pip packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one ends up being tricky.
We know that system packages for pyside6 are coming; they are already available for Ubuntu Oracular and Debian Sid.
However, as a matter of course we don't usually add in keys for pre-release distributions.
There are 2 ways we could go here:
- Take in this
python3-pyside6-pip
key for now, and later add in apython3-pyside6
key. - Right now go for a
python3-pyside6
key, and fill it out withpip
for everything except for very new Ubuntu and Debian distributions.
Personally, I think we should go for 2, but I can be convinced otherwise.
@mjcarroll @alsora Any thoughts here?
I also think number 2 is a better option, but there is one small issue with it. |
Yeah, agreed. However, we can do that piecemeal. What particular parts of PySide6 are you interested in? |
I agree with option 2. |
That works. I currrently need Should there be one key named |
I would start with individual keys. That gives packagers maximum control. If it turns out that there is really a need for a "consolidated" key, we can always add that in later. |
I've updated the |
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
Changes since review
bullseye: | ||
pip: | ||
packages: [PySide6] | ||
sid: [libpyside6-dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sid: [libpyside6-dev] | |
trixie: [libpyside6-dev] | |
sid: [libpyside6-dev] |
Add the current Debian Testing distribution as well. I would even consider dropping the sid
definition altogether in favor of just trixie but don't mind it being there.
It's worth making the change for each of the definitions below as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 590b6ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this made CI unhappy
ERR: list out of alphabetical order line 8526. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8551. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8557. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8563. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8569. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8575. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8581. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8587. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8593. 'sid' should come before 'trixie'
ERR: list out of alphabetical order line 8599. 'sid' should come before 'trixie'
Trixie is the current testing distribution of Debian. * https://packages.debian.org/trixie/python3-pyside6.qtasyncio * https://packages.debian.org/trixie/python3-pyside6.qtcharts * https://packages.debian.org/trixie/python3-pyside6.qtconcurrent * https://packages.debian.org/trixie/python3-pyside6.qtcore * https://packages.debian.org/trixie/python3-pyside6.qtdatavisualization * https://packages.debian.org/trixie/python3-pyside6.qtgui * https://packages.debian.org/trixie/python3-pyside6.qtqml * https://packages.debian.org/trixie/python3-pyside6.qttest * https://packages.debian.org/trixie/python3-pyside6.qtwidgets
@sloretz I modified the PR to include trixie definitions, would you please give it an updated review with my changes. |
I'd intentionally tried to keep these in release order rather than lexicographical order but I forgot that the checker would dislike this.
Please add the following dependency to the rosdep database.
Package name:
PySide6
Package Upstream Source:
https://github.com/qtproject/pyside-pyside-setup
Purpose of using this:
This package is a Python wrapper for Qt 6. It allows one to create Qt applications using Python.
Links to Distribution Packages