Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup error checking in urdfdom #104

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Cleanup error checking in urdfdom #104

wants to merge 5 commits into from

Commits on Feb 7, 2019

  1. Cleanup error checking in model.cpp. 

    There are 2 main things done here:

1.  Check the return value from parseMaterial, parseLink, and
    parseJoint.  While these can throw a ParseError exception,
    most often they return false when they fail to parse.
2.  Revamp the error checking around those calls so that the
    code is indented a lot less.  It is much easier to read this way.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    46ea808 View commit details
    Browse the repository at this point in the history

  2. Slightly cleanup link.cpp. 

    Just make the code flow easier to understand.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    c10d5ad View commit details
    Browse the repository at this point in the history

  3. Add in tests for new, more restrictive parsing. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    0389481 View commit details
    Browse the repository at this point in the history

  4. Remove trailing whitespace from link.cpp 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    173dc7c View commit details
    Browse the repository at this point in the history

  5. Quiet down the tests. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    bb16265 View commit details
    Browse the repository at this point in the history