Fix assumptions that CMAKE_INSTALL_*DIR paths are relative.
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopsided98
force-pushed
the
cmake-install-absolute
branch
6 times, most recently
from
a627bd3
to
cbe6884
Compare
lopsided98
changed the title
CMAKE_INSTALL_*DIR paths are relative.
|
I updated this PR to work with the latest version and I would appreciate feedback on it. It would be great to get this included upstream because we rely on it to build urdfdom in nixpkgs. |
lopsided98
force-pushed
the
cmake-install-absolute
branch
from
cbe6884
to
244edd2
Compare
|
I fixed the conflicts. |
lopsided98
force-pushed
the
cmake-install-absolute
branch
from
244edd2
to
6b9318d
Compare
When an absolute path is desired, the CMAKE_INSTALL_FULL_*DIR variables should be used instead of concatenating with CMAKE_INSTALL_PREFIX. Special handling is also needed for pkg-config and CMake config files to retain relative paths if the lib/include directories are subdirectories of the install prefix. Signed-off-by: Ben Wolsieffer <[email protected]>
lopsided98
force-pushed
the
cmake-install-absolute
branch
from
6b9318d
to
61a7e35
Compare
|
Fixed the conflicts. |
muellerbernd
added a commit
to muellerbernd/urdfdom
that referenced
this pull request
Jan 29, 2024
muellerbernd
added a commit
to muellerbernd/urdfdom
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Bernd Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMAKE_INSTALL_*DIR variables are not guaranteed to be relative to the install prefix.
See https://github.com/jtojnar/cmake-snips#assuming-cmake_install_dir-is-relative-path for more information.