Skip to content

[shape_msgs] New Bounds Msg #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

[shape_msgs] New Bounds Msg #278

wants to merge 1 commit into from

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Apr 30, 2025

This is the definition of Bounds from ros-simulation/simulation_interfaces#1

I feel it should be moved to this upstream package for some future distro.

Signed-off-by: David V. Lu <[email protected]>
@mjcarroll
Copy link
Member

Added to PMC agenda for May 6th.


# bounds type
uint8 TYPE_EMPTY = 0 # No bounds. The points vector will be empty.
uint8 TYPE_BOX = 1 # Axis-aligned bounding box, points field should have two values,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What frame is the axis aligned bounding box aligned to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an entirely reasonable question, and looking back, there is no frame specification anywhere. @adamdbrw was there a conversation about this in ros-simulation/simulation_interfaces#1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is specified:
For entities, these limits are relative to entity's canonical link transform, following ROS rep-103 convention.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-pmc-minutes-for-may-6-2025/43576/1

@tfoote
Copy link
Contributor

tfoote commented May 13, 2025

There does not seem to be a significant difference between this proposal and https://github.com/ros2/common_interfaces/blob/rolling/shape_msgs/msg/SolidPrimitive.msg

What's the semantic difference and why does it have the slightly different list of primatives selected?

@wjwwood wjwwood added help wanted Extra attention is needed backlog labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants