Avoid calling send() on awaiting native coroutine objects #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #962
Rationale
If a native coroutine (i.e.
async def
) is to be called manually (i.e. usingu = f(); while True: u.send(None)
, instead ofasyncio.create_task
), like in the case of ourTask
class, then thesend
call should only be done when the coroutine is ready to execute code (i.e. when it has finished anawait
line). This can be examined by storing the future object returned by thesend
function.Disclaimer
Please review carefully (especially if this is to be backported), as I'm not too confident about the side-effects this one might have. Thanks!