Added rmw_security_common #388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
fujitatomoya
requested changes
Jan 29, 2025
Comment on lines
60
to
61
| // const std::string & prefix, const std::string & secure_root, | ||
| // std::unordered_map<std::string, std::string> & result); |
There was a problem hiding this comment.
remove those comments?
Suggested change
| // const std::string & prefix, const std::string & secure_root, | |
| // std::unordered_map<std::string, std::string> & result); |
| @@ -0,0 +1,99 @@ | |||
| // Copyright 2021 Open Source Robotics Foundation, Inc. | |||
There was a problem hiding this comment.
basically what we are doing here is to move the implementation from rmw_dds_common, but it also adjusts the implementation in C. probably copyright year would be better to be updated? and else where.
Suggested change
| // Copyright 2021 Open Source Robotics Foundation, Inc. | |
| // Copyright 2025 Open Source Robotics Foundation, Inc. |
| * \param[in] prefix An optional prefix to apply to the filenames when storing them. | ||
| * \param[in] secure_root The path to the security enclave to look at. | ||
| * \param[out] result The map where the friendly name -> filename pairs are stored. | ||
| * \return `true` if all required files exist in the security enclave, `false` otherwise. |
There was a problem hiding this comment.
this is not correct.
Suggested change
| * \return `true` if all required files exist in the security enclave, `false` otherwise. | |
| * \return `RMW_RET_OK` if successful, or | |
| * \return `RMW_RET_INVALID_ARGUMENT` if any argument are invalid, or | |
| * \return `RMW_RET_ERROR` an unexpected error occurs. |
| * \param[in] prefix An optional prefix to apply to the filenames when storing them. | ||
| * \param[in] secure_root The path to the security enclave to look at. | ||
| * \param[out] result The map where the friendly name -> filename pairs are stored. | ||
| * \return `true` if all required files exist in the security enclave, `false` otherwise. |
There was a problem hiding this comment.
this is not correct.
Suggested change
| * \return `true` if all required files exist in the security enclave, `false` otherwise. | |
| * \return `RMW_RET_OK` if successful, or | |
| * \return `RMW_RET_INVALID_ARGUMENT` if any argument are invalid, or | |
| * \return `RMW_RET_ERROR` an unexpected error occurs. |
This was referenced Jan 30, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ros2/sros2#330
the new
rmw_zenoh_cpphas an open PR to include certificates using the--enclaveargument. This requires to usermw_dds_common::get_security_fileswhich is not a dds unique utility.The idea with new package is to include here all the security common things.
As discussed in the ROS weekly meeting, we decided to include this package under the rmw repository and it should use C in the signature as the other rmw functions.
Related PRs