This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Use height instead of max-height#14
Open
shanavas786 wants to merge 1 commit intoroszpun:masterfrom
shanavas786:use-height
Open
Use height instead of max-height#14shanavas786 wants to merge 1 commit intoroszpun:masterfrom shanavas786:use-height
shanavas786 wants to merge 1 commit intoroszpun:masterfrom
shanavas786:use-height
Conversation
Fixes rendering if the wrapper is taller than 500px
Owner
|
This would break css transition so there animation will not work.I think I should replace it with dynamic styles and JS height calculation. |
|
To keep the transition and make it work on bigger heights, setting a bigger max-height should do the trick (like 1500px to handle big contents) and increasing transition time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rendering for wrapper taller than 500px