Managesieve plugin: option to append original subject in out-of-office auto-replies #8570
Conversation
|
The PR is broken. Please, clean that up. |
marczi
force-pushed
the
managesieve-vacation-append-subject
branch
from
5099572 to
dd6b3b7
Compare
|
Dear @alecpl I've rebased master, I hope it is good now. If so, I'll also fix my other PR. Thanks |
|
It is not. See the "Files changed" tab here. |
|
Dear @alecpl , thanks for checking and the patience, I see, it's my first attempt.., I'm going to continue fixing |
marczi
force-pushed
the
managesieve-vacation-append-subject
branch
from
dd6b3b7 to
8a320c7
Compare
marczi
force-pushed
the
managesieve-vacation-append-subject
branch
from
8a320c7 to
de15f5c
Compare
|
Dear @alecpl I think it is fine now, only those files are affected that I've modified. It is based now on the latest master. If it is fine, I'm going to fix my other PR the same way |
|
This feature was requested in #5258 |
|
It looks good now, it will take time to review it. |
|
Take your time, thanks for your help so far. I'm going to fix my other PR and comment there when it is done. |
|
Please, resolve conflicts. |
|
Dear @alecpl I've fixed the conflicts. Can you please check why I got browser_tests failed? I suppose it is unrelated to my modifications |
This PR adds a checkbox both to the "out of office" tab and in the sieve rule editor for the vacation module.
When checkbox is on, then the original subject is appended to the automatically sent reply.
The implementation follows what the old sieverules plugin did and uses a hidden rule that sets the original subject in a sieve variable. (This is method is also recommended on Dovecot mailing lists)