-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password driver for the gandi.net mail API #8684
base: master
Are you sure you want to change the base?
Conversation
Added new config options for the gandi API
fixed some bugs
fixed some formatting issues
Fixed some formatting issues
some more cleanup
Added documentation
fixed typo
removed unneeded dependency
fixed some typo
fixed another typo
fixed typo
Added german translation
Added english translation
Added english translation
Fixed formatting issue
Fixed formatting issue
Added english translation
Added german translation
Removed redundant information
Added translation support
Added translations for the gandi-API
Fixed some formatting issues
Added translation for the gandi mail-API
Fixed typo
Added translation for the gandi mail-API
Added translation for the gandi mail-API
Added translation for the gandi mail-API
Don't add localizations, they need to be done via Transifex. They will got removed when we sync the localization. |
Added translation for the gandi mail-API
Improved configuration.
Improved config description
Fixed some formatting issues
fixed some bugs
Fixed bug where users of domains with multiple mailboxes could not login
fixed typo
Happy to hear that (-: |
Transifex pulls it automatically from en_US.inc (from master branch, i.e. after it's merged). |
I hesitate to merge this because gandi.net is not open-source nor can be installed on premises. Am I wrong? Also, its password policy is very non-generic, i.e. we need an extra localization label to handle that. |
Yes, gandi.net is a domain provider and although their API is very well documented, it is not open-source. And yes, there is no (clean) way to add password policy other than through localization labels. While I'd be very happy to see this merged, I also see the issue with closed source code, so you'll have to decide. |
Added support for personal access tokens (pats)
Added support for personal access tokens (pats)
fixed wrong authentication method
Added backwards compatibility for legacy API keys
Added backwards compatibility for legacy API keys
I recently switched to Roundcube and was surprised to see how well designed this app is.
However, when setting up the password plugin, I noticed that there is no password driver for my provider.
So I did the only reasonable thing and coded one myself.
The driver uses the gandi.net mail API (https://api.gandi.net/docs/email/) to update the user password. It also includes a strength driver that conforms to the gandi.net rules for changing passwords, and of course some translations and documentation. It has been tested with PHP 7.4 on Roundcube 1.6.
This took al lot of work and I would really appreciate it if you would look over it and consider a merge.