Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding BIMI Support #8759

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

InputOutputZ
Copy link

Adding BIMI Support

Adding BIMI Support
@alecpl
Copy link
Member

alecpl commented Oct 25, 2022

I think that a better place for this would be in program/actions/contacts/photo.php. Also, the content will have to be secured using rcmail_attachment_handler::svg_filter(). Finally, I'd probably store the svg file in the temp folder so every user could just use it skipping the DNS request.

@InputOutputZ
Copy link
Author

InputOutputZ commented Oct 25, 2022

Aha, I agree. I'm not sure how to properly use the plugins framework, therefore when you have time, please have a look at it. I will try to pick things from and perhaps use it in future contributions.

With thanks.

@alecpl
Copy link
Member

alecpl commented Oct 26, 2022

Actually you could use identicon plugin as an example. It does exactly what you need.

@candrews
Copy link

I've submitted a PR that adds a bimi plugin: #8860

The plugin supports caching and does svg filtering as discussed here in this PR. I'm eager to receive feedback and 🤞 get it merged 😄

@knofte
Copy link

knofte commented Jun 25, 2024

How's this going?
Would be great to get bimi support (without VMC) in base :)

@Neustradamus
Copy link

Neustradamus commented Nov 21, 2024

If someone can update the @candrews PR or this @InputOutputZ PR with latest BIMI draft version?

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants