Conversation
|
@Nilirad can the CI workflow be approved please? |
| }, | ||
| ); | ||
| ) { | ||
| error!("Failed to add resource: {:?}", e); |
There was a problem hiding this comment.
This error message is inaccurate, the error is coming from insert on Assets.
The docs mention that this method will not fail for uuid assets, so the error could be safely ignored.
Although it might be appropriate to use the fallible version of resource_mut. I think this could be missing if a user fails to add rendering features/plugins.
if let Some(mut materials) = app.world_mut().get_resource_mut::<Assets<ColorMaterial>>() {
// `insert` will not fail for uuid assets
let _ = materials.insert(
&COLOR_MATERIAL_HANDLE,
ColorMaterial {
color: Color::WHITE,
..default()
},
);
} else {
error!("Failed to get Assets<ColorMaterial> resource");
}
There was a problem hiding this comment.
Is the code compiling without errors for you?
There was a problem hiding this comment.
Are you referencing the error you commented about earlier, or something about this particular review feedback?
I suppose either way, the answer is yes.
There was a problem hiding this comment.
never mind, seems to have fixed itself
| let m = build_mesh(&buffers); | ||
| if let (Some(mut aabb), Some(new_aabb)) = (aabb, m.compute_aabb()) { | ||
| *aabb = new_aabb; | ||
| } | ||
| mesh.0 = meshes.add(m); |
There was a problem hiding this comment.
Is this fixing or working around a bug that's documented somewhere? I'm surprised that modern Bevy isn't automatically recomputing the Aabb.
|
I did this over in #292, but please feel free to open a PR/issue for the |
Closes rparrett#284 Closes rparrett#285 Re-implemented on top of the `bevy_prototype_lyon` 0.14 changes with the suggestions from rparrett#285 code review and an additional fix for CI. Co-authored-by: Fangdun Tsai <fundon@pindash.io>
|
Sorry, I was hiking last week. |
3 participants
Upgrade to bevy
0.17.0