spec: Remove unused dependency on "check" pkg-config file#2763
Merged
Conversation
The Check library is not used anywhere now. It seems the build-time dependency was copied from libdnf project, without actually being used at that time either.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the unused pkgconfig(check) build dependency from the dnf5.spec file. I have no further feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
m-blaha
approved these changes
Jun 3, 2026
m-blaha
left a comment
m-blaha
left a comment
Member
There was a problem hiding this comment.
Thanks, it's unused leftover from the libdnf days...
Merged
via the queue into
rpm-software-management:main
with commit Jun 3, 2026
28702d0
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Check library is not used anywhere now. It seems the build-time dependency was copied from libdnf project, without actually being used at that time either.