Don't use --allowerasing with 'dnf download'

[cottsay]

This isn't a valid argument to the download verb.

Repro:

$ mock --dnf-cmd -- download --source filesystem
...
Unknown argument "--allowerasing" for command "download". Add "--help" for more information about the arguments.
...

[gemini-code-assist]

Code Review

This pull request updates the default configuration options in mock/py/mockbuild/config.py by adding the --allowerasing flag to the download command. This ensures consistency with other package management commands such as makecache, search, and info. I have no feedback to provide as there were no review comments.

[xsuchy]

LGTM.
Can you please add release notes entry? https://github.com/rpm-software-management/mock/blob/main/docs/Release-Notes-New-Entry.md

[praiskup]

/packit test

[cottsay]

Can you please add release notes entry?

Sure, done in 7c16c3f. Thanks!

[praiskup]

06:08:07 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/001-orphanskill-explicit.tst
06:08:14 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/002-copyin.tst
06:08:16 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/01-shell.tst
06:08:17 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/02-argpassing.tst
06:08:18 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/03-chroot-one-arg.tst
06:08:31 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/04-offline-tmpfs.tst
06:12:11 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/05-orphanskill-std.tst
06:12:20 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/06-retcode.tst
06:12:27 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/07-init-clean.tst
06:12:34 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/08-oldstyle-cmd.tst
06:12:43 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/09-mockchain-fail.tst
06:13:08 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/10-mockchain-partial.tst
06:13:36 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/11-mockchain-success.tst
06:14:22 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/12-mockchain-recurse.tst
06:15:29 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/13-mockchain-gen-br.tst
06:16:09 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/14-mock-multiple.tst
06:16:09 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/15-overlayfs-layers.tst
06:16:10 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/16-spec-and-multiple-srpms-fail.tst
06:16:17 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/17-spec-and-rebuild.tst
06:16:28 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/18-spec-sources-and-rebuild.tst
06:16:52 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/19-sign-plugin.tst
06:18:07 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/20-lvm-plugin.tst
06:19:10 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/21-mockchain-image.tst
06:19:36 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/22-rootdir.tst
06:20:38 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/23-local-mirrorlist.tst
06:21:33 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/24-postinstall.tst
06:22:51 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/25-postupdate-root-cache.tst
06:22:52 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/26-external-deps.tst
06:23:47 stdout: * PASSED: /tmp/tmp.iWsBwo4Idg-mock-old-tests/mock/integration-tests/27-nspawn.tst
06:24:17 stdout: PASSED: alma+epel-10-x86_64.cfg (tmpfs)
06:24:29 stdout: PASSED: alma+epel-10-x86_64.cfg
06:25:00 stdout: PASSED: alma+epel-10-x86_64_v2.cfg (tmpfs)
06:25:10 stdout: PASSED: alma+epel-10-x86_64_v2.cfg
06:26:31 stdout: PASSED: alma+epel-8-x86_64.cfg (tmpfs)
06:27:07 stdout: PASSED: alma+epel-8-x86_64.cfg
06:27:50 stdout: PASSED: alma+epel-9-x86_64.cfg (tmpfs)
06:28:01 stdout: PASSED: alma+epel-9-x86_64.cfg
06:28:32 stdout: PASSED: alma-kitten+epel-10-x86_64.cfg (tmpfs)
06:28:42 stdout: PASSED: alma-kitten+epel-10-x86_64.cfg
06:29:13 stdout: PASSED: alma-kitten+epel-10-x86_64_v2.cfg (tmpfs)
06:29:22 stdout: PASSED: alma-kitten+epel-10-x86_64_v2.cfg
06:29:48 stdout: PASSED: almalinux-10-x86_64.cfg (tmpfs)
06:29:57 stdout: PASSED: almalinux-10-x86_64.cfg
06:30:23 stdout: PASSED: almalinux-10-x86_64_v2.cfg (tmpfs)
06:30:32 stdout: PASSED: almalinux-10-x86_64_v2.cfg
06:31:30 stdout: PASSED: almalinux-8-x86_64.cfg (tmpfs)
06:31:45 stdout: PASSED: almalinux-8-x86_64.cfg
06:32:15 stdout: PASSED: almalinux-9-x86_64.cfg (tmpfs)
06:32:25 stdout: PASSED: almalinux-9-x86_64.cfg
06:32:50 stdout: PASSED: almalinux-kitten-10-x86_64.cfg (tmpfs)
06:32:59 stdout: PASSED: almalinux-kitten-10-x86_64.cfg
06:33:24 stdout: PASSED: almalinux-kitten-10-x86_64_v2.cfg (tmpfs)
06:33:33 stdout: PASSED: almalinux-kitten-10-x86_64_v2.cfg
06:35:15 stdout: PASSED: anolis-8-x86_64.cfg (tmpfs)
06:35:29 stdout: PASSED: anolis-8-x86_64.cfg
06:35:48 stdout: PASSED: azure-linux-3-x86_64.cfg (tmpfs)
06:35:56 stdout: PASSED: azure-linux-3-x86_64.cfg
06:36:46 stdout: PASSED: centos-stream-10-x86_64.cfg (tmpfs)
06:36:57 stdout: PASSED: centos-stream-10-x86_64.cfg