fix: reload uidManager with chrootuid/chrootgid from config

[praiskup]

The uidManager was initialized before config was loaded, so it always used the calling user's UID/GID for privilege dropping. When config specifies a different chrootuid/chrootgid, the uidManager needs to be reloaded with those values — otherwise operations run under the wrong identity, leading to permission errors in the chroot.

Move uidManager initialization after command_parse() (which doesn't need to drop privileges) and reload it with chrootuid/chrootgid from config_opts right after config is loaded (loaded with dropped privileges).

Fixes: #1731

Assisted-By: Claude Code (claude-opus-4-6)

[praiskup]

/packit test

[gemini-code-assist]

Code Review

This pull request ensures that the uidManager is reloaded with the chrootuid and chrootgid specified in the configuration, rather than always using the calling user's identity. This involves moving the UID manager initialization and adding a new reload_uidmanager function. Review feedback pointed out that the new function and its variables should follow the project's snake_case naming convention and that the docstring should adhere to the Google style guide.

[gemini-code-assist]

The function name reload_uidmanager and its internal variables unprivuid/unprivgid do not adhere to the project's naming conventions. Additionally, the docstring should follow the Google style for consistency with the rest of the project.

• Naming: Use snake_case for functions and variables (e.g., reload_uid_manager, unpriv_uid).
• Docstrings: Include Args and Returns sections as per Google style.

def reload_uid_manager(uid_manager, config_opts):
    """Re-create UidManager with chrootuid/chrootgid from config.

    Args:
        uid_manager (UidManager): The current UID manager instance.
        config_opts (dict): Configuration options containing chrootuid and optionally chrootgid.

    Returns:
        UidManager: A new UidManager instance initialized with the configured IDs.
    """
    unpriv_uid = config_opts["chrootuid"]
    unpriv_gid = config_opts.get("chrootgid", uid_manager.unprivGid)
    return UidManager(unpriv_uid, unpriv_gid)

References

1. Functions should use lowercase with underscores (snake_case). ^(link)
2. Variables should use lowercase with underscores (snake_case). ^(link)
3. Use Google style docstrings for all docstrings. ^(link)

[xsuchy]

+1