Skip to content

Workaround for resizing window problem on Windows 10 #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hamayama wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Workaround for resizing window problem on Windows 10 #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/agent/Scraper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,18 @@ void Scraper::resizeImpl(const ConsoleScreenBufferInfo &origInfo)
{
// Resize the buffer to the final desired size.
m_console.setFrozen(false);

// Workaround for the windows console crash if resizing screen so that
// the cursor is hidden on Windows 10.
// ( https://github.com/microsoft/terminal/issues/1976 )
const auto info = m_consoleBuffer->bufferInfo();
m_consoleBuffer->setCursorPosition(Coord(0, 0));

m_consoleBuffer->resizeBufferRange(finalBufferSize);

// Restore cursor position from the above workaround.
m_consoleBuffer->setCursorPosition(Coord(info.cursorPosition().X,
info.cursorPosition().Y));
}

{
Expand Down