Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace default tooltips 'n/a' #629

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

replace default tooltips 'n/a' #629

wants to merge 2 commits into from

Conversation

4-1-1
Copy link

@4-1-1 4-1-1 commented Aug 23, 2018 •
edited
Loading

Enable the ability to Change the init display, not only 'n/a'

@4-1-1
replace default tooltips 'n/a'
30df660 
Enable the ability to Change the init display but 'n/a'
@rrag
Copy link
Owner

rrag commented Sep 3, 2018

Thank you. can you give me an example where x and y initial display will be different?

Being consistent with OHLCTooltip would be my choice

adding a na prop and using it like here
https://github.com/rrag/react-stockcharts/blob/master/src/lib/tooltip/OHLCTooltip.js#L103

@4-1-1
Copy link
Author

4-1-1 commented Sep 5, 2018

@rrag Yes, you are right, one props should be enough
@benmccann I'm sorry to do not run the code before commit, It's my mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4-1-1 @rrag @benmccann