Improved load-on-pan events #690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good luck with this PR. Unfortunately, @rrag didn't answer to any PR for a long time. So people ended up forking and using their own versions. |
|
@aleksspeaker would you recommend any fork in particular? I like this library, but the fact that it doesn't seem to be maintained is a concern. Thanks! |
|
Hi @payala , |
bikkimahato
reviewed
Sep 14, 2022
| const start = head(xScale.domain()); | ||
| const end = xAccessor(firstItem); | ||
| const scale_start = head(xScale.domain()); | ||
| const data_start = xAccessor(firstItem); | ||
| // console.log(start, end, start < end ? "Load more" : "I have it"); |
There was a problem hiding this comment.
Commented code should not be pushed to GitHub.
There was a problem hiding this comment.
... and the comment isn't even part of the PR 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the fix suggested in issue #688
3 new events have been added:
I have left onLoadMore unchanged for now, so that this fix wont break anything. If we go this route, I recommend deprecating it as soon as possible to make the API more consistent.
Alternatively, we break backwards compatibility and use onLoadMore for everything 😄