This repository was archived by the owner on Jul 7, 2020. It is now read-only.
reader: add Close method #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Close method closes the ReaderAtCloser that underlies the Reader.
fawick
reviewed
Aug 2, 2017
| @@ -75,9 +75,15 @@ import ( | |||
| "strconv" | |||
| ) | |||
|
|
|||
| // ReaderAtCloser combines the io.ReaderAt and io.Closer interfaces. | |||
| type ReaderAtCloser interface { | |||
There was a problem hiding this comment.
I'd suggest naming this type ReadAtCloser. That would be consistent with how io.Reader and io.ReadCloser are combined in io.ReadCloser instead of io.ReaderCloser. There are more examples for this in io.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the library in a server and don't want to have file descriptors leaking.
The way I implemented it now changes the API so it may not be welcome. We could instead add a NewReaderAtCloser() (*ReaderAtCloser, error) function. The ReaderAtCloser could embed a Reader and thus offer the same functionality without changing the API for existing users.