feat: wallet supportedBrowsers from backoffice flags [SUP-868] - #477
Merged
Conversation
Dominikkq
marked this pull request as ready for review
August 6, 2026 09:33
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Dominikkq
requested review from
alexjavabraz,
annipi,
lserra-iov and
spoletijuan
August 6, 2026 09:45
Resolve conflicts in favor of the branch: keep the backoffice feature-flags service, its wiring and tests, which the revert on main (676deb0) had removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Resolve conflicts in favor of the branch: keep the backoffice feature-flags service, its wiring and tests, which the revert on main (676deb0) had removed.
…to feat-SUP-868
…t-SUP-868 # Conflicts: # package-lock.json # package.json
# Conflicts: # ENV_VARIABLES.md # src/__tests__/unit/features.controller.unit.ts # src/__tests__/unit/services/backoffice-feature-flags.service.unit.ts # src/controllers/features.controller.ts # src/services/backoffice-feature-flags.service.ts
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates /features merging so wallet (and other) feature properties (e.g. supportedBrowsers) can be driven by backoffice flags rather than hardcoded API logic.
Changes:
- Split backoffice flags into boolean “feature toggles” and “property flags” that attach non-boolean values onto the matching feature row.
- Extend
upsertFeatureto apply derived feature attributes when inserting/updating merged features. - Update unit tests and ENV docs to cover/explain property-flag behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/services/backoffice-feature-flags.service.ts | Adds property-flag parsing and applies derived attributes during feature merge. |
| src/tests/unit/services/backoffice-feature-flags.service.unit.ts | Adds unit tests validating property-flag attachment and edge cases (longest match, reserved fields, orphan flags). |
| ENV_VARIABLES.md | Documents property-flag naming rules and reserved fields behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lserra-iov
approved these changes
Aug 10, 2026
spoletijuan
approved these changes
Aug 11, 2026
annipi
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Wallet browser support now comes from backoffice flags instead of being
hardcoded in the API.
on the wallet_ledger row in /features. This works for any feature and any
model property, no hardcoded lists.
dates on merged rows.
Task:
SUP-868