Add devmode settings to the config file - #2
Open
M-Picco wants to merge 4 commits into
Open
Conversation
|
I'm not seeing anything wrong, LGTM. |
ignaciopulicedonatto
self-requested a review
August 24, 2020 18:06
ignaciopulicedonatto
approved these changes
Aug 24, 2020
M-Picco
marked this pull request as ready for review
August 24, 2020 19:29
… value sign (pos = enable, neg = disable)
M-Picco
force-pushed
the
devmode-config
branch
from
August 31, 2020 18:09
cba88f4 to
b71ff4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this PR removes the devmode settings defined through macros in the file
rsktestconfig.hin favor of them being present in the config file, thus avoiding the need of recompilations when the settings need to be altered.