Add test for when batched pegout exceed max tx size

[julia-zack]

rskj:mtmu-integration

[Copilot]

Pull request overview

Adds a new full-execution 2WP integration test to validate Bridge behavior when a batched pegout would exceed the maximum standard BTC transaction size, ensuring the Bridge splits the batch and emits correct per-split events.

Changes:

• Import MAX_STANDARD_TX_SIZE_ALLOWED into the 2WP test suite.
• Add a new pegout test that seeds many federation UTXOs, creates multiple pegout requests in one RSK block, triggers release, and asserts:
  • the batch is split into multiple BTC transactions,
  • release_requested.amount is logged per split (not total),
  • each resulting BTC tx virtualSize() is within MAX_STANDARD_TX_SIZE_ALLOWED.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

lib/tests/2wp.js:2022

• This test’s own Arrange comment states the Bridge creates one BTC transaction per surviving batch across consecutive pegout creation cycles, but the test only calls triggerRelease once. triggerRelease advances to the next pegout creation height a single time (via increaseBlockToNextPegoutHeight) and then drives that one pegout through confirmation/signing/broadcast, so a second split batch may never be created/broadcast in this test. This can make the assertions about expectedBatchPegoutTxs = 2 and the final empty pegoutRequests queue fail or become flaky.

Consider looping releases until the bridge queue is drained (or explicitly triggering a second pegout-creation cycle when requests remain) before collecting events and asserting split counts.

                await triggerRelease(rskTxHelpers, btcTxHelper);

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud