Skip to content

feat(rsdoctor-analysis): select compiler before analysis - #124

Merged
yifancong merged 3 commits into
mainfrom
feat-rsdoctor-compiler-selection
Oct 22, 2026
Merged

yifancong merged 3 commits into
mainfrom
feat-rsdoctor-compiler-selection

Conversation

@yifancong

Copy link
Copy Markdown
Contributor

Summary

Update the Rsdoctor analysis workflow to discover compilers before fetching evidence and keep one selected compiler across the full analysis. Multi-compiler reports now follow the user's requested target, ambiguous targets require a choice, legacy reports omit --compiler, and unavailable compiler data stops analysis before partial results are produced.

Document compilers list, compilers_list, --compiler, and recovery for compiler selection errors in the command reference.

Related: web-infra-dev/rsdoctor#1885, web-infra-dev/rsdoctor#2003

Validation

  • pnpm run check
  • quick_validate.py skills/rsdoctor-analysis

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T07:53:27.565364Z eb799ac Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 363a286efc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/rsdoctor-analysis/SKILL.md Outdated
@yifancong
yifancong marked this pull request as draft September 15, 2026 09:42
@yifancong
yifancong marked this pull request as ready for review October 19, 2026 07:49
@yifancong
yifancong requested a review from SoonIter October 19, 2026 07:49
@yifancong
yifancong enabled auto-merge (squash) October 19, 2026 07:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb799ac208

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/rsdoctor-analysis/SKILL.md
@yifancong
yifancong merged commit 2ee8100 into main Oct 22, 2026
4 checks passed
@yifancong
yifancong deleted the feat-rsdoctor-compiler-selection branch October 22, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants