fix: inherit Timesheet controller from HRMS EmployeeTimesheet and correct naming overrides - #1392
Open
ManyaGirdhar wants to merge 2 commits into
Open
ManyaGirdhar wants to merge 2 commits into
ManyaGirdhar wants to merge 2 commits into
Conversation
wreckage0907
left a comment
Contributor
There was a problem hiding this comment.
@niraj2477 the change for project is just a rename hence theres not gonna be any change that will be affected as we were already inherting from hrms .
for timesheet , the only override hrms does is on function set_status which sets the status to different things based on if theres a payslip attached or invoice generated which we are not using in our setup ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inherit Timesheet Controller from HRMS EmployeeTimesheet and correct naming overrides
TimesheetOverrideintimesheet.pyfrom core ERPNextTimesheettohrms.overrides.employee_timesheet.EmployeeTimesheet.hooks.py,project.py, andtimesheet.pyfromOverwritetoOverrideto ensure correct resolution by Frappe framework.Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
Fixes #