feat: Implement structured error handling and response - #186
Open
namankhare wants to merge 5 commits into
Open
namankhare wants to merge 5 commits into
namankhare wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The frontend contract is broken, Drive failures can be misclassified, and raw run diagnostics are exposed.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Introduces normalized Inngest run-status responses with structured, actionable failure details.
Changes:
- Adds run-status and error response models.
- Classifies Inngest and Google Drive failures.
- Expands endpoint documentation and response examples.
File summaries
| File | Description |
|---|---|
app/inngest_proxy/service.py |
Normalizes run responses and builds error details. |
app/inngest_proxy/models/models.py |
Defines response schemas and status enums. |
app/inngest_proxy/models/__init__.py |
Exports the new models. |
app/inngest_proxy/errors.py |
Adds failure classification and formatting. |
app/inngest_proxy/controller.py |
Publishes the normalized response contract. |
app/google_docs/services/google_auth.py |
Exposes the service-account email. |
app/google_docs/services/folder_manager.py |
Adds parent-folder accessibility checks. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 3
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…iled errors in InngestProxyService
…ing in FolderManagerService
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.