Repository navigation
fix(recording): preserve queued audio and prepare 1.2.1 - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stopping just after the native capture helper exits raised before the controller drained buffered PCM, leaving queued audio out of the saved recording. Make Stop idempotent for an exited helper, including exit during the pipe write, so queued audio is journaled while EOF, overflow and nonzero exits remain visible.
The Windows preparation helper also accepted inconsistent source-header/runtime metadata. Validate runtime, installer and bundle workflow versions/channels before tests and recheck them after tests/builds. Synchronize the upcoming patch version to 1.2.1.
Testing
Risks
Local MP3 integration was skipped because the clean PyAV runtime is absent. Final installed-package Teams recording, minimized feedback and final signing/notarization remain release gates. This PR does not publish a release.