Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions source/meeting_intelligence.py
Original file line number Diff line number Diff line change
Expand Up @@ -872,10 +872,11 @@ def _json_response(raw, label):
def _references(value, allowed, *, required=True):
if (not isinstance(value, list) or len(value) > MAX_CITATIONS
or (required and not value)
or any(not isinstance(item, str) or item not in allowed for item in value)
or len(set(value)) != len(value)):
or any(not isinstance(item, str) or item not in allowed for item in value)):
raise ValueError(tr("O modelo citou segmentos ausentes ou inválidos; o resultado anterior foi preservado."))
return list(value)
# The native citation enum permits repeated valid IDs. Normalize them
# without accepting unknown IDs or weakening the input-size bound.
return list(dict.fromkeys(value))

@staticmethod
def _output_limit(budget):
Expand Down
54 changes: 54 additions & 0 deletions source/tests/test_meeting_intelligence.py
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,60 @@ def invalid(_prompt, _evidence):
self.assertTrue(runtime.closed)
self.assertEqual(self.store.get(self.session_id)["summary"], {"summary": "Prior report"})

def test_repeated_valid_report_citations_are_normalized(self):
def response(_prompt, evidence):
report = self._report(evidence)
report["segment_ids"] *= 2
report["action_items"][0]["segment_ids"] *= 2
return json.dumps(report)

intelligence, runtime = self._intelligence(response)
result = intelligence.generate_report(self.session_id, DEFAULT_SUMMARY_MODEL)
self.assertEqual(result["segment_ids"], ["s1"])
self.assertEqual(result["action_items"][0]["segment_ids"], ["s1"])
self.assertEqual(self.store.get(self.session_id)["summary"], result)
self.assertTrue(runtime.closed)

def test_repeated_valid_citations_survive_hierarchical_report_reduction(self):
revision = self.store.begin_revision(self.session_id, "local", "pt")
for index in range(3):
self.store.add_transcript(self.session_id, revision, {
"id": f"long-{index}", "track": "microphone",
"start": index * 5, "end": (index + 1) * 5,
"text": "Alice will review the report by Friday. " * 40,
})
self.store.finish_revision(self.session_id, revision)

def response(_prompt, evidence):
report = self._report(evidence)
report["segment_ids"] *= 2
report["action_items"][0]["segment_ids"] *= 2
return json.dumps(report)

intelligence, runtime = self._intelligence(response)
result = intelligence.generate_report(self.session_id, DEFAULT_SUMMARY_MODEL)
self.assertGreater(result["chunks_processed"], 1)
self.assertGreater(len(runtime.calls), result["chunks_processed"])
self.assertEqual(result["segment_ids"], ["long-0"])
self.assertEqual(result["action_items"][0]["segment_ids"], ["long-0"])
self.assertTrue(runtime.closed)

def test_unknown_report_citations_are_not_dropped_with_valid_duplicates(self):
for field in ("report", "action"):
def response(_prompt, evidence):
report = self._report(evidence)
target = report if field == "report" else report["action_items"][0]
target["segment_ids"] = ["s1", "s1", "invented"]
return json.dumps(report)

with self.subTest(field=field):
intelligence, runtime = self._intelligence(response)
with self.assertRaisesRegex(ValueError, "segmentos"):
intelligence.generate_report(self.session_id, DEFAULT_SUMMARY_MODEL)
self.assertEqual(self.store.get(self.session_id)["summary"],
{"summary": "Prior report"})
self.assertTrue(runtime.closed)

def test_ask_this_meeting_is_memory_only_and_returns_citations_and_uncertainty(self):
def answer(_prompt, evidence):
identifier = evidence[0].get("id") or evidence[0].get("segment_ids", [])[0]
Expand Down
Loading