Skip to content

fix(build): target-aware stack flag so windows-gnu toolchain links #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
galaxy-luke wants to merge 1 commit into
base: develop
Choose a base branch
from
+10 −1
Open

fix(build): target-aware stack flag so windows-gnu toolchain links #2539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,16 @@ fn main() {
// main-thread stack during process startup. Reserve a larger stack for
// the CLI binary so `rtk.exe --version`, `--help`, and hook entry
// points start reliably without requiring ad-hoc RUSTFLAGS.
println!("cargo:rustc-link-arg=/STACK:8388608");
//
// NOTE: build.rs `cfg(target_env)` reflects the *host* target, not the
// *target* being compiled. Read CARGO's TARGET env var to pick the
// correct linker syntax (MSVC vs GNU).
let target = std::env::var("TARGET").unwrap_or_default();
if target.contains("msvc") {
println!("cargo:rustc-link-arg=/STACK:8388608");
} else if target.contains("gnu") {
println!("cargo:rustc-link-arg=-Wl,--stack,8388608");
}
}

let filters_dir = Path::new("src/filters");
Expand Down