fix(git): keep status paths relative to cwd#2542
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2373.
Summary
rtk git statuspaths relative to the caller's current subdirectory../..., matching nativegit status --shortRoot cause
Compact status uses
git status --porcelain -b, whose v1 porcelain paths are repo-root relative. In a monorepo subdirectory, that made RTK print paths likeapps/web/local_subdir/file.pywhile native git status printslocal_subdir/file.py.Validation
cargo fmt --allcargo test test_build_status_commandcargo test test_format_status_output_relativecargo test test_git_status_paths_are_relative_to_current_subdir -- --ignoredcargo clippy --all-targetscargo test --all