fix(filter): preserve inline comment markers in code#2546
Open
andiahmads wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk read --level minimalno longer drops valid source lines just because they contain comment-looking markers inside strings or inline expressions. Before this fix, a Rust line likelet glob = "packages/*";could enter block-comment mode and hide that line plus following code until a later*/appeared.The filter now treats block comments as removable only when the trimmed line starts with the block-comment opener, preserving inline markers while still removing full-line single-line and multi-line block comments.
Closes #2385.
Testing
rtk cargo test core::filterrtk cargo fmt --all --checkrtk cargo testrtk cargo clippy --all-targetsPost-Deploy Monitoring & Validation
No additional operational monitoring required. This is a local CLI filtering fix with regression coverage and no service, deployment, or runtime infrastructure surface.