Skip to content

fix(cargo): preserve quiet check success output#2567

Open
YOMXXX wants to merge 1 commit into
rtk-ai:developfrom
YOMXXX:fix/issue-2545-cargo-check-quiet
Open

fix(cargo): preserve quiet check success output#2567
YOMXXX wants to merge 1 commit into
rtk-ai:developfrom
YOMXXX:fix/issue-2545-cargo-check-quiet

Conversation

@YOMXXX

@YOMXXX YOMXXX commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve empty cargo build/check output instead of synthesizing cargo build (0 crates compiled)
  • Add streaming and buffered regression tests for quiet successful cargo output

Fixes #2545

Verification

  • cargo +1.93.0 test quiet_success_preserves_empty_output -- --nocapture
  • cargo +1.93.0 test cargo_build -- --nocapture
  • cargo +1.93.0 fmt --all -- --check
  • cargo +1.93.0 clippy --all-targets
  • cargo +1.93.0 test --all -- --skip small_grep_not_worse_than_plain
  • git diff --check
  • cargo +1.93.0 run --quiet -- cargo check -q (status=0, bytes=0)

Note: small_grep_not_worse_than_plain is a known upstream baseline failure on develop, so the broad test run skips only that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rtk causes many false positive iteratoins for cargo check -q command with GPT 5.4 mini model

1 participant