Skip to content

fix(rewrite): preserve stdin-driven commands#2575

Open
YOMXXX wants to merge 1 commit into
rtk-ai:developfrom
YOMXXX:fix/issue-2431-stdin-sensitive-rewrite
Open

fix(rewrite): preserve stdin-driven commands#2575
YOMXXX wants to merge 1 commit into
rtk-ai:developfrom
YOMXXX:fix/issue-2431-stdin-sensitive-rewrite

Conversation

@YOMXXX

@YOMXXX YOMXXX commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • skip hook rewrites for stdin-sensitive commands such as wrangler secret put/bulk, kubectl/oc -f -, docker/podman build -, and git/yadm apply
  • avoid rewriting upstream pipe producers when a downstream pipe segment consumes stdin
  • skip rewrites for commands with input redirection while preserving normal file/context rewrites

Fixes #2431

Tests

  • cargo +1.93.0 test registry -- --nocapture
  • cargo +1.93.0 run --quiet -- rewrite "kubectl apply -f -"
  • cargo +1.93.0 run --quiet -- rewrite "cat manifest.yaml | kubectl apply -f -"
  • cargo +1.93.0 run --quiet -- rewrite "cat secret.json | wrangler secret bulk --name worker"
  • cargo +1.93.0 run --quiet -- rewrite "kubectl apply -f manifest.yaml"
  • cargo +1.93.0 run --quiet -- rewrite "docker build ."
  • cargo +1.93.0 fmt --check
  • git diff --check
  • cargo +1.93.0 clippy --all-targets
  • cargo +1.93.0 test --all -- --skip small_grep_not_worse_than_plain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-rewrite hook drops stdin → wrangler secret put/bulk silently store empty values

1 participant