fix(next): don't force next build for other subcommands#2846
Closed
ErezAmihud wants to merge 1 commit into
Closed
Conversation
`rtk next dev`/`rtk npx next dev` always ran `next build` regardless of the requested subcommand, silently turning `dev`, `start`, `lint`, etc. into a build. Only build (or no subcommand) now routes through the build-output filter; anything else runs unfiltered passthrough. Fixes rtk-ai#2840 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
Author
|
Not the "correct" solution to the problem. The problem lies in the npx rewrite rules. see #2854 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk next dev/rtk npx next devalways rannext buildregardless of the requested subcommand, silently turningdev,start,lint, etc. into a build. Only build (or no subcommand) now routes through the build-output filter; anything else runs unfiltered passthrough.Fixes #2840
Test plan
I added tests for the commands and ran it manually to check it works
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected