Skip to content

ci: fix Windows CRT mismatch and mark CUDA non-blocking #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pszymkowiak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: fix Windows CRT mismatch and mark CUDA non-blocking #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ jobs:
test:
name: ${{ matrix.name }}
runs-on: ${{ matrix.os }}
# CUDA matrix entries are best-effort: GH-hosted runners' kernel mismatch
# currently breaks nvidia-dkms (Jimver/cuda-toolkit action). Mirror the
# non-blocking behavior already applied in release.yml.
continue-on-error: ${{ matrix.cuda == true }}
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -58,6 +62,16 @@ jobs:
cuda: '12.6.3'
method: network

# esaxx-rs forces /MT via .static_crt(true) but ort-sys prebuilt links
# against /MD. Force /MD on Windows so cc's last flag wins and the
# CRT matches ort-sys. Without this, link fails with LNK2038.
- name: Set Windows MSVC runtime flags
if: runner.os == 'Windows'
shell: pwsh
run: |
echo "CFLAGS=/MD" >> $env:GITHUB_ENV
echo "CXXFLAGS=/MD" >> $env:GITHUB_ENV

- name: Cache cargo
uses: actions/cache@v4
with:
Expand Down
Loading