-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job for CI using Prism parser #1980
Conversation
c2f7c53
to
b9c213a
Compare
But ruby-head is prism already, isn’t this sufficient? |
Ah yes, probably so. I'll keep this in draft and look at it again next week. |
My understanding is that it will still use the plain parser gem, even with ruby-head/ruby-3.4 |
Thanks for the hint, @Earlopain ! I’m good with a separate ci job with prism. |
As a user, you would set For reference, here's the PR for |
.github/workflows/main.yml
Outdated
bundler-cache: true | ||
- env: | ||
PARSER_ENGINE: parser_prism | ||
run: NO_COVERAGE=true bundle exec rake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs generator is broken with Ruby 2.7, I openend rubocop/rubocop#13388. Probably, you can just run bundle exec rake spec
here regardless. I don't think the other tasks really need to run with prism.
b9c213a
to
befe7f0
Compare
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
befe7f0
to
d5c48e6
Compare
I changed it to run only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you♥
Inspired by rubocop/rubocop-capybara#112
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).