Skip to content

Drop ruby-head from test matrix to keep builds stable #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2025
Merged

Drop ruby-head from test matrix to keep builds stable #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f43e7e
Remove ruby-head version from test matrix
numbata May 22, 2025
ac8c20d
Fix rubocop offenses
numbata May 22, 2025
bac60d8
Update CHANGELOG
numbata May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
needs: ['rubocop']
strategy:
matrix:
ruby-version: ['3.0', '3.1', '3.2', '3.3', 'head']
ruby-version: ['3.0', '3.1', '3.2', '3.3', '3.4']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 3.0, as you mentioned in the description, and maybe replacing head by 3.5-dev

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have 3.0 as a requirement in the gemspec.
What if I just change the PR description for now. And add 3.5-dev with ruby-head in a separate pull request where we can focus on supporting exactly 3.5?

steps:
- name: Check out branch
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#### Fixes

* Your contribution here.

* [#388](https://github.com/ruby-grape/grape-entity/pull/388): Drop ruby-head from test matrix to keep builds stable - [@numbata](https://github.com/numbata).

### ### 1.0.1 (2024-04-10)

Expand Down
4 changes: 2 additions & 2 deletions bench/serializing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class Teacher < Models::Person
attr_accessor :tenure

def initialize(opts = {})
super(opts)
super
@tenure = opts[:tenure]
end
end
Expand All @@ -44,7 +44,7 @@ class Student < Models::Person
attr_reader :grade

def initialize(opts = {})
super(opts)
super
@grade = opts[:grade]
end
end
Expand Down
2 changes: 1 addition & 1 deletion grape-entity.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Gem::Specification.new do |s|

s.required_ruby_version = '>= 3.0'

s.add_runtime_dependency 'activesupport', '>= 3.0.0'
s.add_dependency 'activesupport', '>= 3.0.0'

s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- {test,spec}/*`.split("\n")
Expand Down