Keep within_namespace
as part of our internal api
#2595
Merged
+67
−157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify
within_namespace
visibility; remove legacynamespace_start
/namespace_end
Motivation
within_namespace
as a private, internal helper for scoping settings safely.namespace_start
/namespace_end
to simplify internals and tests.Changes
within_namespace
remains private inGrape::DSL::Settings
and continues to be used internally by DSL methods (e.g.,namespace
,version
,scope
).lib/grape/dsl/settings.rb
and corresponding specs.Impact
namespace
usage is unaffected.namespace
,group
,resources
, etc.).Tests
within_namespace
private; removed legacy helper references.