BigMath.erf/erfc with Bitburst algorithm #458
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to implement bitburst-algorithm version of
BigMath.erfandBigMath.erfcThis pull request is a proof of concept, not meant to merge.
Considering the complexity of the implementation, (about 1/3 of math.rb code are about erf/erfc), I'm not sure if this improvement is worth maintaining.
Requires #407, #433 and #434
Bit-burst algorithm implementation
Repeatedly apply Taylor expansion at increasing x.
x0 + x1 + x2 + ...f(x0)with Taylor expansion offat0f(x0 + x1)with Taylor expansion offatx0f(x0 + x1 + x2)with Taylor expansion offatx0 + x1Each Taylor expansion calculation uses binary-splitting method.
Details are described in source code comment.
Benchmark
Performance compared with initial implementation of erf/erfc (#357)
(multiplication-improvement(#407) exp-improvement(#433) pi-improvement(#434))