Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify vterm-yamatanooroti's steps #1060

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Simplify vterm-yamatanooroti's steps #1060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,10 @@ jobs:
fail-fast: false
env:
WITH_LATEST_RELINE: ${{matrix.with_latest_reline}}
WITH_VTERM: 1
timeout-minutes: 30
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Install libvterm
run: |
sudo apt install -y libtool-bin
Expand All @@ -98,8 +94,10 @@ jobs:
sed -i -e 's/^PREFIX=.*$/PREFIX=\/usr/g' Makefile
make
sudo make install
- name: Install dependencies
run: |
WITH_VTERM=1 bundle install
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This automatically runs bundled install and caches the result, so we don't need a separate step for it. Putting it after libvterm installation to make sure we have all the dependencies needed for gems.

- name: rake test_yamatanooroti
run: WITH_VTERM=1 bundle exec rake test_yamatanooroti
run: bundle exec rake test_yamatanooroti
Loading