Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Update #search documentation #347

Merged
merged 2 commits into from
Nov 7, 2024
Merged

📚 Update #search documentation #347

merged 2 commits into from
Nov 7, 2024

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Nov 7, 2024

  • Expanded criteria docs:
    • explain sequence-set coercion
    • explain encoding of string, integer, and date args
    • add warning for raw string data
  • Expanded charset docs
    • Link to IANA charset registry
    • Indicate defaults are "US-ASCII" or "UTF-8"
    • Demonstrate sending charset embedded inside criteria
  • Move #search example above search criteria. The list of search keys
    is long. And to be more complete, it will need to get even longer.
    It's nice to have some examples near the top.
  • Update #search example (NEW is deprecated)
    NEW and RECENT have been removed from IMAP4rev2, so I'm updating
    the example with a search key that isn't deprecated.
  • Fix CONDSTORE example
  • Document all known standard search keys, including extensions, rather than only a small subset

* Expanded criteria docs:
  * explain sequence-set coercion
  * explain encoding of string, integer, and date args
  * add warning for raw string data
* Expanded charset docs
  * Link to IANA charset registry
  * Indicate defaults are "US-ASCII" or "UTF-8"
  * Demonstrate sending charset embedded inside criteria
* Move `#search` example above search criteria.  The list of search keys
  is long.  And to be more complete, it will need to get even longer.
  It's nice to have some examples near the top.
* Update `#search` example (`NEW` is deprecated)
  `NEW` and `RECENT` have been removed from `IMAP4rev2`, so I'm updating
  the example with a search key that isn't deprecated.
Rather than only list a subset of search keys, this documents them all.
@nevans nevans merged commit 14205d5 into master Nov 7, 2024
22 checks passed
@nevans nevans deleted the search-docs branch November 7, 2024 23:28
@nevans nevans added the documentation Improvements or additions to documentation label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

1 participant