Don't leak the global verbose flag into the test runner's ARGV#747
Merged
Conversation
The global verbose flag is also set by --trace and -n, so deriving the test runner's -v from it leaked -v into the test process ARGV and broke apps that inspect ARGV at load time. Keep echoing the command for the global flag, but base the -v injection only on the task's own @verbose. Fixes #732 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
It is a helper, not a test case, so keep it under private like the other helpers in the test suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--traceand-nset the global verbose flag, which since 13.4.2 causedTestTaskto append-vto TESTOPTS. The:rakeloader passes that-von to the test process ARGV, breaking apps that inspect ARGV at load time (e.g. Sinatra) underrake test --trace.The task block now keeps echoing the command for the global flag but bases the
-vinjection only on the task's own@verbose, sot.verbose = trueandTESTOPTS=-vare unchanged.Fixes #732