Skip to content

Make IO.binread, IO.binwrite, IO.read and IO.write accept _ToPath #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ksss merged 4 commits into from
May 12, 2025
Merged

Make IO.binread, IO.binwrite, IO.read and IO.write accept _ToPath #2378

ksss merged 4 commits into from
May 12, 2025

Conversation

@KitaitiMakoto
Copy link
Contributor

@KitaitiMakoto KitaitiMakoto commented Apr 1, 2025

Hi,

I found IO.binread, IO.binwrite, IO.read and IO.write's signatures don't allow Pathname for the first argument and fixed it.

Thanks.

ksss
ksss reviewed Apr 2, 2025
View reviewed changes
@KitaitiMakoto
Copy link
Contributor Author

KitaitiMakoto commented Apr 3, 2025

@ksss
Thank you for the advice. I fixed.

@ksss ksss added this pull request to the merge queue May 12, 2025
@ksss ksss added this to the RBS 4.0 milestone May 12, 2025
Merged via the queue into ruby:master with commit 35e422d May 12, 2025
20 checks passed
@KitaitiMakoto KitaitiMakoto deleted the io-read-write branch May 12, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksss ksss ksss left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

RBS 4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@KitaitiMakoto @ksss