Fix nil size Enumerator test
#2749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is a fix for ruby/ruby#15541. |
If the `size` is `nil`, which means the size is unknown: 1. Test with loop but break after 10,000 loops. 2. If the object has more than 10,000 objects, assume it’s an infinite loop. This is clearly broken for enumerators with more than 10,000 but fixed size. But it works for tests.
soutaro
added a commit
that referenced
this pull request
Dec 16, 2025
Fix `nil` size `Enumerator` test
soutaro
added a commit
that referenced
this pull request
Dec 16, 2025
Merge pull request #2749 from ruby/fix-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
sizeisnil, which means the size is unknown:This is clearly broken for enumerators with more than 10,000 but fixed size. But it works for tests.