Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cloudflare-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout PR Code
uses: actions/checkout@v5
uses: actions/checkout@v6
with:
repository: ${{ github.event.client_payload.pr_checkout_repository }}
ref: ${{ github.event.client_payload.pr_head_sha }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
if: ${{ github.repository == 'ruby/rdoc' && !startsWith(github.event_name, 'pull') }}
steps:
- name: Checkout
uses: actions/checkout@v5
uses: actions/checkout@v6
- name: Setup Ruby
uses: ruby/setup-ruby@eaecf785f6a34567a6d97f686bbb7bccc1ac1e5c # v1.237.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5 # v3.3.0
- uses: actions/checkout@v6 # v3.3.0
# libyaml-dev is needed for psych, see https://github.com/ruby/setup-ruby/issues/409
- if: ${{ matrix.os == 'ubuntu-latest' }}
run: sudo apt install libyaml-dev
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push_gem.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
with:
egress-policy: audit

- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou please note: although @dependabot intended to upgrade this action to v6 in this PR, the SHA-versioned lines (three in total, I think) were in fact updated to v5.0.1.

The more-recent Dependabot PR #1490 has fixed this and updated to v6.0.1 -- even so, I would not currently recommend mixing SHA-versioned and tag-versioned references to the same action within a single repository's GitHub Actions workflows.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. How about this? #1493

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the improved versioning comments in that PR are helpful. I'd add a caution, though, that, as I understand it, Dependabot alerts are not able to scan and issue vulnerability notices for actions referenced from workflow files using SHA1 referencing. I learned that from the somewhat-popular, yet-to-be-resolved discussion thread titled Please make Dependabot Alerts support SHA-hash-versioned GitHub Actions at: https://github.com/orgs/community/discussions/154189


- name: Set up Ruby
uses: ruby/setup-ruby@eaecf785f6a34567a6d97f686bbb7bccc1ac1e5c # v1.237.0
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ruby-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
bundler: none
- name: Save latest buildable revision to environment
run: echo "REF=$(ruby -v | cut -d')' -f1 | cut -d' ' -f5)" >> $GITHUB_ENV
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v3.1.0
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v3.1.0
with:
repository: ruby/ruby
path: ruby/ruby
Expand All @@ -51,7 +51,7 @@ jobs:
autoconf
./configure -C --disable-install-doc
working-directory: ruby/ruby
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v3.1.0
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v3.1.0
with:
path: ruby/rdoc
- name: Build RDoc locally
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:

runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v5 # v3.3.0
- uses: actions/checkout@v6 # v3.3.0
# libyaml-dev is needed for psych, see https://github.com/ruby/setup-ruby/issues/409
- if: ${{ matrix.os == 'ubuntu-latest' }}
run: sudo apt install libyaml-dev
Expand Down
Loading