Remove the per-example runtime log hook from the spec helper - #9673
Merged
Merged
Conversation
turbo_tests balances workers by a recorded runtime log only when invoked as a bare `spec`; this build passes an absolute spec/bundler path, so it grouped by file size and let the single heaviest file dominate the wall-clock. A tool/ patch loaded from the recipe records per-file runtimes and reorders the size-based grouper to use the previous run's data, leaving the synced spec/bin/parallel_rspec untouched. This forward-ports only the spec_helper.rb part of the ruby/ruby commit. The opt-in per-example runtime log is superseded there by the tool/-side recorder, so the hook is removed to keep the synced trees identical. The common.mk and tool/ changes stay in ruby/ruby. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the opt-in BUNDLER_SPEC_RUNTIME_LOG per-example runtime logging hook from the RSpec helper, aligning this repository’s synced Bundler spec helper behavior with upstream (where runtime logging has moved to Ruby’s tool/ patching for test-bundler-parallel).
Changes:
- Deletes the
BUNDLER_SPEC_RUNTIME_LOGenv-var hook that recorded per-example durations into per-worker log files. - Removes the associated
before(:each)/after(:each)hooks and instance variable usage used solely for that logging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This forward-ports the
spec/bundler/spec_helper.rbpart of ruby/ruby#17647. That PR moved per-file runtime recording fortest-bundler-parallelinto atool/patch on the ruby/ruby side, so the opt-inBUNDLER_SPEC_RUNTIME_LOGhook in the synced spec helper is superseded. Removing it here keeps the synced trees identical. Otherwise the next rubygems to ruby sync would resurrect the hook in ruby/ruby. Thecommon.mkandtool/changes stay in ruby/ruby.ruby/ruby@508b486
The ported diff is byte-identical to the original hunk and
bin/rubocopreports no offenses on the touched file.Generated with Claude Code