Add specs for Module.used_refinements

[moozzi]

#1016
[Feature #14332]

Module.used_refinements has been added.

[andrykonchin]

suggestion: There are the following additional cases that I would consider:

• a module doesn't have imported refinements at all, so used_refinements returns []
• a module includes another module that calls using and imports some refinement - this refinement shouldn't be returned by calling #used_refinements in the child module

[moozzi]

Could You please provide an example of second suggestion?

[andrykonchin]

Do you mean an example of usage of ScratchPad? There is an example in another my comment #1027 (comment):

# language/next_spec.rb
ScratchPad.record []
 
[1].each do |i|
  begin
    ScratchPad << :begin
    next
  ensure
    ScratchPad << :ensure
  end
end
 
ScratchPad.recorded.should == [:begin, :ensure]

[moozzi]

I was thinking about this
a module includes another module that calls using and imports some refinement - this refinement shouldn't be returned by calling #used_refinements in the child module
Sorry if previous comment was unclear.

[andrykonchin]

I was thinking about this
a module includes another module that calls using and imports some refinement - this refinement shouldn't be returned by calling #used_refinements in the child module
Sorry if previous comment was unclear.

I meant the following case:

# it ignores refinements imported in a module that is included into the current one

m1 = Module.new do
  refine Integer do
  end
end

m2 = Module.new do
  using m1
end

Module.new do
  include m2

  p Module.used_refinements # => I would expect `[]`
end

There is another case that may be worth to check - when some refinements are declared in a module, that is included in a module that is passed as argument for using method:

# it returns refinements even not defined directly in a module refinements are imported from

m1 = Module.new do
  refine Integer do
  end
end

m2 = Module.new do
  include m1
end

Module.new do
  using m2

  p Module.used_refinements # => [#<refinement:Integer@#<Module:0x000000010391f3d0>>]
end

[andrykonchin]

Thank you for the specs!